From: Florian Müllner <fmuellner@gnome.org>
Date: Mon, 11 May 2020 23:12:50 +0000 (+0200)
Subject: extensionSystem: Don't log error name
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~367
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=48e6a58250fd0f59acbed48ee5c222b459c875d8;p=gnome-shell.git

extensionSystem: Don't log error name

logExtensionError() currently saves the error message by calling
toString() on the passed error. That's convenient as it allows to
pass a string instead of a "proper" error, but the result isn't
great for the common Error case: Its toString() method prefixes
the message with the error name, which usually is just "Error:".

The plain message is more suitable for displaying it to users,
so use that for Error objects.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2337
---

diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js
index 50244d95f..f0b836171 100644
--- a/js/ui/extensionSystem.js
+++ b/js/ui/extensionSystem.js
@@ -260,7 +260,8 @@ var ExtensionManager = class {
         if (!extension)
             return;
 
-        let message = error.toString();
+        const message = error instanceof Error
+            ? error.message : error.toString();
 
         extension.error = message;
         extension.state = ExtensionState.ERROR;